[vsipl++] [patch] more cleanup with benchmarks

[Stefan Seefeld]

Don,

Stefan Seefeld wrote:
> Don McCoy wrote:

>> Index: configure.ac
>> ===================================================================
>> --- configure.ac	(revision 172077)
>> +++ configure.ac	(working copy)
>> @@ -230,6 +230,11 @@
>>  
>>    AC_CHECK_PROGS(CC_SPU, [spu-gcc])
>>    AC_CHECK_PROGS(EMBED_SPU, [ppu-embedspu embedspu])
>> +  AC_PROG_CXX(ppu-g++ g++)
>> +  AC_PROG_CC(ppu-gcc gcc)
>> +  CXXFLAGS="-m32 $CXXFLAGS"
>> +  LDFLAGS="-m32 $LDFLAGS"
>> +  CFLAGS="-m32 $CFLAGS"
>>  
>>    AC_DEFINE_UNQUOTED(VSIP_IMPL_CBE_SDK, 1,
>>          [Set to 1 to support Cell Broadband Engine.])
> 
> I'm not sure the above is valid. At least I would very carefully check
> autoconf docs, because:
> 
> * We already call AC_PROG_CXX (et al.) earlier in configure.ac, and I
>   wouldn't be surprised if there were side-effects introduced by this double appearance.

Here is a slightly reworked patch (for configure.ac) that addresses my concern:
AC_PROG_CXX and AC_PROG_CC are called once, but with context-dependent arguments.
I can't pretend to fully understand the involved m4 macros, or even the generated
configure script, but the general conditional logic appears to be fine now.

What do you think ?

Thanks,
		Stefan

-- 
Stefan Seefeld
CodeSourcery
stefan at codesourcery.com
(650) 331-3385 x718
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure.ac.diff
Type: text/x-patch
Size: 1057 bytes
Desc: not available
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20070523/29784748/attachment.bin>