[vsipl++] [patch] more cleanup with benchmarks

[Stefan Seefeld]

Don McCoy wrote:
> This patch is really two seperate ones.  The configure change was as a
> result of today's discussion, but the other changes were from last week
> -- apparently I forgot to post this.
> 
> Ok to commit?
> 
> Regards,
> 
> 
> ------------------------------------------------------------------------
> 
> 2007-05-23  Don McCoy  <don at codesourcery.com>
> 
> 	* configure.ac: Search for the compilers that come with the Cell SDK
> 	  over the default system ones (gcc and g++).
> 	* benchmarks/cell/bw.cpp: Remove debug code.
> 	* benchmarks/makefile.standalone.in: Allow configuration
> 	  parameters to set build variables to default values.
> 	* benchmarks/hpec_kernel/GNUmakefile.inc.in: Conditionalize
> 	  building of SVD benchmark on whether or not LAPACK is available.
> 
> 
> ------------------------------------------------------------------------
> 
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 172077)
> +++ configure.ac	(working copy)
> @@ -230,6 +230,11 @@
>  
>    AC_CHECK_PROGS(CC_SPU, [spu-gcc])
>    AC_CHECK_PROGS(EMBED_SPU, [ppu-embedspu embedspu])
> +  AC_PROG_CXX(ppu-g++ g++)
> +  AC_PROG_CC(ppu-gcc gcc)
> +  CXXFLAGS="-m32 $CXXFLAGS"
> +  LDFLAGS="-m32 $LDFLAGS"
> +  CFLAGS="-m32 $CFLAGS"
>  
>    AC_DEFINE_UNQUOTED(VSIP_IMPL_CBE_SDK, 1,
>          [Set to 1 to support Cell Broadband Engine.])

I'm not sure the above is valid. At least I would very carefully check
autoconf docs, because:

* We already call AC_PROG_CXX (et al.) earlier in configure.ac, and I
  wouldn't be surprised if there were side-effects introduced by this double appearance.

* You only present a very limited choice of compilers (admittedly still sufficient
  for that particular platform, at this time).

Regards,
		Stefan

PS: Please make sure checkins remain atomic, i.e. don't address unrelated issues.
    This makes it easier to roll back, or merge, if ever we must.


-- 
Stefan Seefeld
CodeSourcery
stefan at codesourcery.com
(650) 331-3385 x718