[vsipl++] [patch] Increase max size of split-complex fast convolution

Jules Bergmann jules at codesourcery.com
Fri Mar 23 19:41:49 UTC 2007


> They still cause a deadlock.  This patch add an alternative, called 
> spe_assert(), though I note that it still hangs in abort(), but at least 
> the messages get out to the console.

That is an improvement.

> 
> Note: we may want to consider using -NDEBUG for release builds of SPE 
> code, as this new version pulls in the stdio header otherwise.  Is the 
> same true with the system assert?

That is a good idea to use -NDEBUG for the SPE cflags when building a 
release.  That shouldn't require any changes to the library itself, but 
should be a matter of configuration options.  I'll handle that in 
scripts/config.

Just to make sure I undertand the impact of including stdio: it is going 
to increase the SPE text size, which may result in our larger problem 
sizes being single buffered instead of double buffered.  However, it 
should not create a correctness issue, i.e. it shouldn't affect stack 
usage if an assertion is not thrown.

I don't know if the SPE system assert pulls in stdio, but I hope not 
since it doesn't actually print anything!

> 
> Still ok to check in?

Yes, please do.

				thanks,
				-- Jules

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705



More information about the vsipl++ mailing list