[patch] Fix subset of subsets; fix IPP FIR backend bug
Jules Bergmann
jules at codesourcery.com
Wed Jan 24 20:50:21 UTC 2007
This patch fixes two bugs:
First, it fixes handling of subset views of distributed subset views.
Previously this worked, but my recent patch to support more arbitrary
distributed subset views broke this.
The fix is to add a specialization of Map_subdomain for Subset_map.
However, this created a header dependency loop between subset_map.hpp,
vector.hpp, and subblock.hpp, because maps' processor_set function
returns a vector. I broke this loop by moving forward declarations of
views into view_fwd.hpp, and by splitting subset_map.hpp into
subset_map_decl.hpp and subset_map.hpp. subset_map_decl.hpp contains
the core declarations of subset_map.hpp, but does not actually require a
definition of Vector. subblock.hpp now includes subset_map_decl.hpp.
A new regression test (regressions/subset.cpp) covers this case.
Second, it fixes a bug in the IPP FIR backend, which was not mirroring
symmetric kernels properly.
Patch applied.
-- Jules
--
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: subset.diff
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20070124/6208e12a/attachment.ksh>
More information about the vsipl++
mailing list