[vsipl++] [patch] Use QMtest CommandHost

[Jules Bergmann]

> Yes, this looks good. (I find --with-qmtest-command not very descriptive --
> as it sounds like the command to invoke qmtest itself -- but a) I don't have
> anything other to suggest and b) chances are that the group of potential
> users for this particular option is rather limitted :-) )

I agree, it does seem to imply it is the qmtest executable (but we have 
'--with-qmtest=QMTEST' for the qmtest executable).

Since the QMtest target class is called CommandHost, how about 
--with-qmtest-commandhost=XXX?



> 
>>      case "$host_cpu" in
>> -      (ia32|i686|x86_64) fftw3_f_simd="--enable-sse"
>> +      ia32|i686|x86_64) fftw3_f_simd="--enable-sse"
>>  	                 fftw3_d_simd="--enable-sse2" 
>>  	                 ;;
>> -      (ppc*)             fftw3_f_simd="--enable-altivec" ;;
>> +      ppc*)             fftw3_f_simd="--enable-altivec" ;;
>>      esac
>>      AC_MSG_NOTICE([fftw3 config options: $fftw3_opts $fftw3_simd.])
> 
> I remember Nathan (ncm) introducing this '(a)' syntax, with some explanation
> about broken shells. How exactly did this fail ?

It fails on solaris.

It doesn't fail when I run configure directly, but it does fail when 
configure is run by the Makefile, if it detects that configure is out of 
data w.r.t. configure.ac.

I noticed similar problems with the atlas configure on gannon a while 
back.  Running atlas configure directly was OK, but running atlas 
configure via the top-level configure made it very picky about syntax.

There must be a flag to enable/disable this ultra-picky mode for 
solaris /bin/sh, but I don't know what it is.

> 
> 
>> Index: tests/GNUmakefile.inc.in
>> ===================================================================
>> --- tests/GNUmakefile.inc.in	(revision 152549)
>> +++ tests/GNUmakefile.inc.in	(working copy)
>> @@ -49,6 +49,7 @@
>>  	  sed -e "s|@CPPFLAGS_@|`$(tests_pkgconfig) --variable=cppflags`|" | \
>>            sed -e "s|@CXXFLAGS_@|`$(tests_pkgconfig) --variable=cxxflags`|" | \
>>            sed -e "s|@LIBS_@|`$(tests_pkgconfig) --libs`|" | \
>> +          sed -e "s|@QMTEST_TARGET_@|`$(tests_pkgconfig) --variable=qmtest_target`|" | \
>>            sed -e "s|@PAR_SERVICE_@|`$(tests_pkgconfig) --variable=par_service`|" \
>>            > tests/context-installed
>>  	cd tests; \
> 
> Doesn't this require that you define the 'qmtest_target' variable in the vsipl++.pc.in
> template, too ?

Yes, good catch.  I forgot to include that file in the patch.  Attached.

					-- Jules

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: qm-cmd.diff
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20061027/54058486/attachment.ksh>