[vsipl++] [patch] Use QMtest CommandHost

[Stefan Seefeld]

Jules Bergmann wrote:
> This patch adds support for using QMTest's CommandHost target to run
> tests with a proxy command.
> 
> This is currently used for PAS on Linux cluster testing.  It could be
> used for general MCOE testing.
> 
> Stefan, is this ok to commit?

Yes, this looks good. (I find --with-qmtest-command not very descriptive --
as it sounds like the command to invoke qmtest itself -- but a) I don't have
anything other to suggest and b) chances are that the group of potential
users for this particular option is rather limitted :-) )

>      case "$host_cpu" in
> -      (ia32|i686|x86_64) fftw3_f_simd="--enable-sse"
> +      ia32|i686|x86_64) fftw3_f_simd="--enable-sse"
>  	                 fftw3_d_simd="--enable-sse2" 
>  	                 ;;
> -      (ppc*)             fftw3_f_simd="--enable-altivec" ;;
> +      ppc*)             fftw3_f_simd="--enable-altivec" ;;
>      esac
>      AC_MSG_NOTICE([fftw3 config options: $fftw3_opts $fftw3_simd.])

I remember Nathan (ncm) introducing this '(a)' syntax, with some explanation
about broken shells. How exactly did this fail ?


> Index: tests/GNUmakefile.inc.in
> ===================================================================
> --- tests/GNUmakefile.inc.in	(revision 152549)
> +++ tests/GNUmakefile.inc.in	(working copy)
> @@ -49,6 +49,7 @@
>  	  sed -e "s|@CPPFLAGS_@|`$(tests_pkgconfig) --variable=cppflags`|" | \
>            sed -e "s|@CXXFLAGS_@|`$(tests_pkgconfig) --variable=cxxflags`|" | \
>            sed -e "s|@LIBS_@|`$(tests_pkgconfig) --libs`|" | \
> +          sed -e "s|@QMTEST_TARGET_@|`$(tests_pkgconfig) --variable=qmtest_target`|" | \
>            sed -e "s|@PAR_SERVICE_@|`$(tests_pkgconfig) --variable=par_service`|" \
>            > tests/context-installed
>  	cd tests; \

Doesn't this require that you define the 'qmtest_target' variable in the vsipl++.pc.in
template, too ?


Thanks,
		Stefan

-- 
Stefan Seefeld
CodeSourcery
stefan at codesourcery.com
(650) 331-3385 x718