[qmtest] Bug in get_extension_directories (base.py) in Windows

[Mark Mitchell]

On Tue, 2003-09-30 at 08:02, Anders Hasselqvist wrote:
> Hi,
> 
> I wanted to set the QMTEST_CLASS_PATH to H:\exjobb\python but
> this doesn't work since the string is split by ':'
> I think it should be ';' in Windows.
> 
> From base.py:
> -------------
> # Start with the directories that the user has specified in the
> # QNTEST_CLASSPATH environment variable.
>   if os.environ.has_key('QMTEST_CLASS_PATH'):
>   dirs = string.split(os.environ['QMTEST_CLASS_PATH'], ':')
> -------------

Thanks for the report.

You are correct; in fact, the QMTest reference manual says that the OS
PATH separator is used.

This patch fixes that problem.

-- 
Mark Mitchell
CodeSourcery, LLC
mark at codesourcery.com
-------------- next part --------------
2003-10-02  Mark Mitchell  <mark at codesourcery.com>

	* qm/test/base.py (get_extension_directories): Use ";" as the
	QMTEST_CLASS_PATH separator on Windows.
	* NEWS: Mention recent improvements.

Index: qm/test/base.py
===================================================================
RCS file: /home/sc/Repository/qm/qm/test/base.py,v
retrieving revision 1.92
diff -c -5 -p -r1.92 base.py
*** qm/test/base.py	22 Sep 2003 04:53:47 -0000	1.92
--- qm/test/base.py	2 Oct 2003 16:24:59 -0000
*************** def get_extension_directories(kind, data
*** 93,103 ****
      assert kind in extension_kinds
          
      # Start with the directories that the user has specified in the
      # QMTEST_CLASS_PATH environment variable.
      if os.environ.has_key('QMTEST_CLASS_PATH'):
!         dirs = string.split(os.environ['QMTEST_CLASS_PATH'], ':')
      else:
          dirs = []
  
      # Search directories specified by the database.
      if database:
--- 93,104 ----
      assert kind in extension_kinds
          
      # Start with the directories that the user has specified in the
      # QMTEST_CLASS_PATH environment variable.
      if os.environ.has_key('QMTEST_CLASS_PATH'):
!         dirs = string.split(os.environ['QMTEST_CLASS_PATH'],
!                             os.pathsep)
      else:
          dirs = []
  
      # Search directories specified by the database.
      if database:
Index: NEWS
===================================================================
RCS file: /home/sc/Repository/qm/NEWS,v
retrieving revision 1.27
diff -c -5 -p -r1.27 NEWS
*** NEWS	8 Sep 2003 06:42:22 -0000	1.27
--- NEWS	2 Oct 2003 16:35:10 -0000
*************** A defect that could cause a multi-thread
*** 43,52 ****
--- 43,58 ----
  to hang if a resource could not be set up has been corrected.
  
  A defect that resulted in resources being created only per run of the
  GUI, rather than once per test run, has been corrected.
  
+ The XML results file format has been improved to make it more
+ readable, and to make it easier to postprocess the XML.
+ 
+ QMTest now correctly uses ";" as the separator in QMTEST_CLASS_PATH on
+ Windows.
+ 
  QM 2.0.4 (Not Yet Released)
  ===========================
  
  A defect that could cause crashes in the RSHTarget class has been
  corrected.