[qmtest] building the documentation via 'python setup.py build_doc'
Stefan Seefeld
seefeld at sympatico.ca
Thu Aug 28 17:03:59 UTC 2003
Mark Mitchell wrote:
>>+ As this command is only ever used on 'posix' platforms, no efford
>>+ has been made to make this code portable to other platforms such
>>+ as 'nt'."""
>
>
> Spelling: "effort", not "efford". Also, there's no need to include the
> OS names in single quotes, but they should be spelled as their
> trademark-holders prefer: "POSIX" and "Windows".
I was actually using the values reported by the os.name attribute, as
that is what lots of modules seem to base their decisions on.
(distutils, for example).
> If you would, please make that change, and heck in diffs1. Thanks!
>
>
>>+ builddir = self.build_temp + '/' + builddir
>
>
> Shouldn't you use os.path.join here and elsewhere? It seems like that's
> hardly any more work, and it means that if someone happens to get Jade
> on Windows, at least it might have a chance of working.
well, I took it out for consistency. Alternatively, I should replace all
other ocurrences of paths containing '/' (such as the path search lists
containing '/usr/share/doc' etc.) by appropriate calls to os.path.join,
too, no ?
Stefan
More information about the qmtest
mailing list