[qmtest] building the documentation via 'python setup.py build_doc'

Mark Mitchell mark at codesourcery.com
Thu Aug 28 16:44:35 UTC 2003


> +    As this command is only ever used on 'posix' platforms, no efford
> +    has been made to make this code portable to other platforms such
> +    as 'nt'."""

Spelling: "effort",  not "efford".  Also, there's no need to include the
OS names in single quotes, but they should be spelled as their
trademark-holders prefer: "POSIX" and "Windows".

If you would, please make that change, and heck in diffs1.  Thanks!

> +        builddir = self.build_temp + '/' + builddir

Shouldn't you use os.path.join here and elsewhere?  It seems like that's
hardly any more work, and it means that if someone happens to get Jade
on Windows, at least it might have a chance of working.

Other than that, diffs2 looks fine.

Thanks!

-- 
Mark Mitchell
CodeSourcery, LLC
mark at codesourcery.com




More information about the qmtest mailing list