[vsipl++] [patch] Install cml_kernels.so

[Brooks Moses]

Jules Bergmann wrote, at 9/19/2008 11:50 AM:
>> That's exactly what my proposed patch does.  :)
>>
>> It just doesn't have any way of distinguishing between the "the right
>> file is already in the right place" case and the "a file from an old
>> install is there already" case.  The behavior you initially objected to
>> is simply that it treats the latter as an instance of the former.
> 
> Sort of, except it introduces the unexpected behavior of not overwriting 
> the old file in other cases.
> 
> We added the installation of cml_kernels.so a few days ago with the 
> express purpose of helping the package build process out.  If it is now 
> in the way, rather than disable it during the build process, let's just 
> remove it altogether.

Well, it's in the way sometimes and necessary sometimes, depending on
the package layout.  The package layout that I'm currently using is one
of the ones where it's necessary, so I definitely don't want to remove
it!  With the patch I proposed, it will do the right thing for all
package layouts.

Anyhow, I have looked at the documentation and discovered that "test"
has a "FILE -ef FILE" check, which will distinguish the relevant cases.
Thus, I proposed a revised version:

	if test ! lib/cml_kernels.so -ef \
            $(DESTDIR)$(libdir)/cml_kernels.so; then \
          $(INSTALL_PROGRAM) lib/cml_kernels.so \
            $(DESTDIR)$(libdir)/cml_kernels.so \
        fi

Is that ok?  That will still overwrite any old files.  :)

- Brooks