[vsipl++] [patch] SSAR opts
Stefan Seefeld
stefan at codesourcery.com
Wed Sep 17 21:37:57 UTC 2008
Jules Bergmann wrote:
> Ok to apply?
> -#if 1
> +#if 0
> #define VERBOSE
> #define SAVE_VIEW(a, b, c) vsip_csl::save_view_as<complex<float>
>(a, b, c)
> #else
In fact, can this literal '1' / '0' be replaced by something more
expressive, if it is indeed needed ? (#if DEBUG, say)
> - s_filt_ = ft_fftm_(fftshift(s_raw, s_filt_));
> + { Scope<user> scope("fftshift-1", n_ * mc_ * sizeof(complex<float>));
> + fftshift(s_raw, s_filt_);
> + }
> + ft_fftm_(s_filt_);
Please add a newline between '{' and the Scope declaration, for
readability (also at some other places).
Otherwise the patch looks fine.
Thanks,
Stefan
--
Stefan Seefeld
CodeSourcery
stefan at codesourcery.com
(650) 331-3385 x718
More information about the vsipl++
mailing list