[vsipl++] [patch] Use new dispatch for reduction functions

[Stefan Seefeld]

Don McCoy wrote:
> This patch completes the transition to the new dispatcher for the 
> matrix-vector and reduction functions.
> 
> Ok to commit?



> Index: src/vsip/core/reductions/functors.hpp
> ===================================================================
> --- src/vsip/core/reductions/functors.hpp	(revision 229176)
> +++ src/vsip/core/reductions/functors.hpp	(working copy)

> @@ -248,6 +249,7 @@
>    static bool done(accum_type) { return false; }
>  };
>  
> +//} // namespace vsip::impl::dispatcher

Can you please remove this redundant comment ?


> Index: src/vsip/core/cvsip/eval_reductions_idx.hpp
> ===================================================================
> --- src/vsip/core/cvsip/eval_reductions_idx.hpp	(revision 229176)
> +++ src/vsip/core/cvsip/eval_reductions_idx.hpp	(working copy)
> @@ -14,12 +14,14 @@
>  /***********************************************************************
>    Included Files
>  ***********************************************************************/
> +#include <iostream>
> +#include <typeinfo>

...as well as the above two include directives ? (I take it you added 
the typeinfo only for debugging purposes, i.e. to be able to print out 
typeid(type).name(), right ?)

Otherwise this looks fine. May I suggest that we now convert the 
signatures from "void(T &, A, ...)" to "T(A, ...)" ? This is one of the 
syntactic features of the new dispatcher, and it makes the code easier 
to understand.

Thanks,
		Stefan

-- 
Stefan Seefeld
CodeSourcery
stefan at codesourcery.com
(650) 331-3385 x718