[vsipl++] [patch] SSAR optimizations for HPEC

[Jules Bergmann]

Don,

Thanks for the feedback!

> Some minor comments below.
> 
> 
>> +  typedef vsip::impl::Layout<2, row2_type, 
>> vsip::impl::Stride_unit_align<128>,
>> +                     vsip::impl::dense_complex_type>
>> +        row_layout_type;
>> +  typedef vsip::impl::Layout<2, col2_type, 
>> vsip::impl::Stride_unit_align<128>,
>> +                 vsip::impl::dense_complex_type>
>> +        col_layout_type;
> 
> Is this solely to get the desired alignment?  Aren't we getting that 
> anyway by specifying  --with-alignment=128 at configure time?  Or is 
> there another reason to use Fast_block<>?

It also gets each row to start with the desired alignment (padding if 
necessary.  --with-alignment=128 only gets 128-byte alignment at the 
start of the matrix.



> For example, would it be less confusing to say
> 
>    fftshift<row>(...)
> 
> to do a swap of the top half of rows with the bottom half?  Likewise 
> with fftshift<col>.  We could fix it so that fftshift() (with no 
> template parameter) would default to doing both (aka a 'normal' fftshift).

That's a good suggestion, I'll give it a try.


> If we are not using the by_ref types, can we just get rid of them?

Will do.

				thanks,
				-- Jules

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705