[vsipl++] patch: enhancements for freqswap()

Jules Bergmann jules at codesourcery.com
Wed Jun 4 12:27:39 UTC 2008


Stefan Seefeld wrote:
> The attached patch reimplements vsip::freqswap(), yielding two important 
> changes:
> 
> * The recently discovered restriction that the input Block type must be 
> allocatable is removed.
> 
> * It uses a return-block optimization, allowing it avoid a temporary 
> view by using expression template techniques.

You're now a fully trained return-block optimization expert! :)

> Note that the algorithm itself was slightly enhanced to allow to operate 
> on a block in-place, therefor removing the constraint that input and 
> output must not alias.

Is the 2D algorithm enhanced too?  I could see the 1D algorithm was 
enhanced, but wasn't about the 2D algorithm.

> 
> OK to commit ?
> 

Yes, this looks good.

				thanks,
				-- Jules
-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705



More information about the vsipl++ mailing list