[vsipl++] [patch] Make configure options more consistent

[Jules Bergmann]

Don McCoy wrote:
> The attached patch changes a number of instances of --enable-* to use
> --with-* instead, in order to make such usages more consistent with
> other options.  The general rule is that --enable is used for features
> and --with is used for specific libraries.

Great!  Thanks for pushing this through!

Let's capture the naming decision in configure.ac.  Something like

# Rational for option naming
#
# The general rule is that --enable is used for features
# and --with is used for specific libraries.
#
# In cases where an option controls both a feature and specifies
# an external library, such as --enable-parallel, --enable should
# be used.  The primary purpose of the option is turning on
# the feature, the secondary purpose is specifying which
# external code to use to enable that feature.


> 
> The deprecated cases now include error messages to help users building
> from source update their configure options (rather than follow the
> default autoconf behavior of silently ignoring unrecognized options). 
> The Quickstart guide has been updated as well.

Sorry to create churn, but I agree with Brooks:

> I think it might be clearer to phrase this as "is obsolete" or "is no
> longer supported" here; that way, when a user runs across this error,
> they have an idea why they got it.

As the error messages are currently written, "--disable-xyz is not 
supported; use --without-xyz instead", it leaves the impression that the 
library is missing some functionality that should be there, and a 
workaround is being suggested.  It would be more clear to say 
"--disable-xyz is obsolete; use --without-xyz instead" or "--disable-xyz 
is incorrect; use --without-xyz" instead, since in some cases we're 
adding checks for options that were never allowed in the first place.

Otherwise, I think the patch looks good.

				-- Jules

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705