[vsipl++] [patch] HPEC Challenge Benchmark, Firbank enhancement

[Jules Bergmann]

Don McCoy wrote:
 > Jules Bergmann wrote:
 >> Stefan Seefeld wrote:
 >>> Could you please consistently either put the access specifier
 >>> ('public') everywhere
 >>> or nowhere ? (I'd prefer nowhere, as for structs it is implied.)
 >>
 >> Sounds good to me.
 >>
 >> Otherwise this looks good.  Please check it in.
 >>
 > Revised as suggested.

Don, If you haven't already, please check this in.  thanks, -- Jules

 >
 > I also corrected the parallel case after doing proper testing and
 > discovering some problems.  It is not necessary to pass local views to
 > this->firbank(), as this is done inside that function for the cases
 > tagged 'Full' and 'Fast'.  This is not an error, per se, it only adds a
 > slight amount of unnecessary overhead.  For the new 'Expr' case, taking
 > the local view is not needed because it is taken after the evaluator
 > dispatches the expression.  Specifically, in the Cell case the local
 > view is taken before splitting it up amongst the SPEs and in the
 > fall-back case, it is taken within the FFT workspace objects.

Sounds good.

 >
 > Secondly, I made sure that when taking the local view that the macro
 > version LOCAL() was used in place of the member .local(), so that when
 > PARALLEL_FIRBANK is not defined, it still works correctly.  This should
 > allow it to work when compiled against the reference implementation (or
 > other).  This was tested as well.

We can safely phase out the LOCAL() macro now, in favor of .local().
The new reference implementation supports parallel VSIPL++.  The old
reference implementation has been decomissioned.

Don't worry about expunging LOCAL() right away (i.e. check this in),
but let's deprecate it going forward.

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705