[vsipl++] Generator expr blocks

Jules Bergmann jules at codesourcery.com
Tue May 8 14:04:40 UTC 2007


Assem Salama wrote:
> Everyone,
>  This patch makes the local_block_type a Subset_block if a normal 
> Block_dist map is used.

Assem,

This looks good, however, can you extend Choose_subblock to handle 
Global_map and Replicated_map?  Both maps should be able to use a 
Subset_block.

Also, you might consider specializing Create_subblock based on the 
RetBlock type rather than Map type, since the RetBlock type is what 
governs the arguments to the constructor.  As currently written, if you 
add a new cases to Choose_subblock (say for Global_map), but forget to 
add it to Create_subblock, you'll get an error.

				-- Jules


-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705



More information about the vsipl++ mailing list