[vsipl++] [patch] HPEC Challenge Benchmark, Firbank enhancement

Jules Bergmann jules at codesourcery.com
Tue May 1 21:36:40 UTC 2007


Stefan Seefeld wrote:
> Don McCoy wrote:
> 
>> Some minor cleanup of the other benchmarks is included.
> 
>> -struct t_firbank_base<T, ImplFull> : public t_local_view<T>
>> +struct t_firbank_base<T, ImplFull> : public t_local_view<T>,  Benchmark_base
> 
> Could you please consistently either put the access specifier ('public') everywhere
> or nowhere ? (I'd prefer nowhere, as for structs it is implied.)

Sounds good to me.

Otherwise this looks good.  Please check it in.

			thanks,
			-- Jules

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705



More information about the vsipl++ mailing list