[vsipl++] maxval_test

[Stefan Seefeld]

Jules Bergmann wrote:
> Assem Salama wrote:
>> Everyone,
>>  This test tests the maxval operator. It creates a vector on a subset
>> of the processors to test the processor mapping.
> 
> Assem,
> 
> 
> This looks good.  Please address the feedback below and then check it in.
> 
>                 thanks,
>                 -- Jules
> 
>> ------------------------------------------------------------------------
> 
> Assem,
> 
> [1] This file should be called tests/maxval.cpp or tests/par_maxval.cpp.
>  The _test suffix isn't necessary for files in the tests directory.

Since this test appears to explicitely test parallel functionality, may I
suggest to put it into tests/parallel/maxal.cpp instead ?

This will be useful when / if we decide to extend our parallel testing harness
(for example by running the tests multiple times, with differing numbers of
processes).

Thanks,
		Stefan

-- 
Stefan Seefeld
CodeSourcery
stefan at codesourcery.com
(650) 331-3385 x718