[vsipl++] [patch] support for non-contiguous rows or columns with Cell FFTM

Jules Bergmann jules at codesourcery.com
Tue Mar 13 18:18:47 UTC 2007


Don,

These change to ppu/fft.cpp looks good.  I have a minor suggestion
below, but otherwise please check it in.

I'll defer to Stefan on the fft_be.cpp changes.  Once he is happy,
please check them in too.

				-- Jules

 > Index: src/vsip/opt/cbe/ppu/fft.cpp
 > ===================================================================

 > -    fftp.ea_input_buffer    = 0;
 > -    fftp.ea_output_buffer   = 0;
 > -    fftp.in_blk_stride      = 0;
 > -    fftp.out_blk_stride     = 0;
 > +    fftp.ea_input_buffer    = reinterpret_cast<unsigned long long>(in);
 > +    fftp.ea_output_buffer   = reinterpret_cast<unsigned long long>(out);
 > +    fftp.in_blk_stride      = 1;  // not applicable in the single 
FFT case
 > +    fftp.out_blk_stride     = 1;

I would keep the strides set to 0 if they're aren't applicable.  That
way, if the SPE kernel needs to check them for some reason, it can
assume non-zero strides are valid.

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705



More information about the vsipl++ mailing list