[vsipl++] Support for parallel generator blocks

[Jules Bergmann]

Assem Salama wrote:
> Jules Bergmann wrote:
>> Assem Salama wrote:
>>> Everyone,
>>>  This patch was submitted a while ago but didn't receive any 
>>> feedback. This patch has a Choose_local_block addition that switches 
>>> between Map_subset_block and Subset_block.
>>
>> Assem,
>>
>> Thanks for resending this.  I did have some feedback from the first 
>> time around, I apologize if you did not see it:
>>
>>
>> This looks good, however, can you extend Choose_subblock to handle 
>> Global_map and Replicated_map?  Both maps should be able to use a 
>> Subset_block.
>>
>> Also, you might consider specializing Create_subblock based on the 
>> RetBlock type rather than Map type, since the RetBlock type is what 
>> governs the arguments to the constructor.  As currently written, if 
>> you add a new cases to Choose_subblock (say for Global_map), but 
>> forget to add it to Create_subblock, you'll get an error.
>>
>>                 -- Jules
>>
> Jules,
>  I am confused. This patch does support Global_map and Replicated map...

Assem,

No, I am confused :).  Sorry!  I was looking at feedback from a previous 
version of the patch.  The patch looks good, please check it in.

				-- Jules

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705