[vsipl++] [patch] CBE Fftm support

[Stefan Seefeld]

Don,

sorry for the late notice, but something caught my eye just now:


Don McCoy wrote:
> Jules Bergmann wrote:
>> This looks good.  Please check it in, modulo Stefan's comments.
>>
> Checked in, revised as attached.

> Index: src/vsip/opt/cbe/ppu/fft.cpp
> ===================================================================

> +class Fft_base
>  {

> +public:
> +  Fft_base(length_type size) 
> +    : twiddle_factors_(alloc_align<ctype>(VSIP_IMPL_ALLOC_ALIGNMENT, size / 4))
>    {

> +    compute_twiddle_factors(size);
>    }

> +  virtual ~Fft_base() 
> +  {
> +    delete(twiddle_factors_);
> +  }

I don't think it is valid to 'delete' memory allocated via alloc_align<>;
you have to free it via free_align(). Or, better yet, use an aligned_array<>
as suggested earlier.

Thanks,
		Stefan

-- 
Stefan Seefeld
CodeSourcery
stefan at codesourcery.com
(650) 331-3385 x718