[vsipl++] [patch] Support for Cell FFT's up to 4K points.

[Jules Bergmann]

Stefan Seefeld wrote:
> Don McCoy wrote:
> 
>>> [5] 128 is probably a good alignment.  However, it is kind of a magic
>>> number that should be a macro (VSIP_IMPL_CELL_DMAALIGNMENT, pick a
>>> good name) to call it out.
>>>
>> Changed to VSIP_IMPL_ALLOC_ALIGNMENT, and am compiling with
>> --with-alignment=128.  I can't think of a compelling reason to make a
>> new macro here, but if someone else can, please identify it.
> 
> I think this is the right thing to do.
> Jules, we quickly talked about this in the past: should we make the implicit
> memory allocation used by Dense<> (i.e. when not using user-storage) use
> alloc_align<> instead of 'new' ?

Dense uses an allocator (specifically 'Aligned_allocator'), not 'new'.

The intent is that if we want to allow users to specify an allocator 
(say for example to allocate memory in a certain region that was 
DMA'able), or if we wanted to export the allocator used by VSIPL++ to 
the user for allocating their own storage that is compatible with what 
Dense would otherwise allocate (allocating memory within a DMA'able 
region again being an example), using an allocator would make this easier.

Of course, we don't have APIs defined for those types of functionality yet.

				-- Jules

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705