[vsipl++] [patch] pwarp

[Jules Bergmann]

Stefan Seefeld wrote:
> Jules Bergmann wrote:
>> I need to put more thought into how handle
>> some of the 8-bit math.  Also, the location of the SPU kernel (in vsip)
>> makes it unsightly to depend on code from vsip_csl.
> 
> Right. We should think a bit about how to decouple that. In particular,
> how to not make the task_manager.hpp file the central repository for all
> tasks / task types.

Yeah, I was thinking about that too.  For library code like this, could 
we move the DEINE_TASK instantiation from task_manager.hpp to the file 
using the task?

Also, we need to capability for users to provide customer kernels that 
VSIPL++ manages the calling of.  Requiring a change to task_manager.hpp 
would make that painful.

>> +
>> +// Structures used in DMAs should be sized in multiples of 128-bits
>> +
>> +typedef struct
>> +{
>> +  float P[9];			// perspective warp matrix
>> +  int   pad[3];
> 
> I'm still not sure whether there are in fact size restrictions for task
> parameters. Or may be they changed between SDK 2.1 and SDK 3.0.
> 

It might even be a pre ALF 2.1 thing.


> 
> Where do these numbers come from ? And what mean the cases ? Could you
> add some comments so casual users (such as myself) are less puzzled ? :-)

These are for a perspective warp matrix pulled at random out of the 
image registration program.

I've attached before and after images showing the effect of these 
particular warp coefficients.

> 
> Finally, could you make suitable modifications to the affected makefiles
> such that 'make install' does the right thing ? I checked in a small
> patch earlier this morning, but that didn't take into account that
> vsip_csl/img/ has subdirectories, so it isn't quite complete.

Ok, will do.  My bad!  Thanks for catching that Brooks and Stefan!

				-- Jules


-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705
-------------- next part --------------
A non-text attachment was scrubbed...
Name: obj-uchar-src.pgm
Type: application/octet-stream
Size: 262159 bytes
Desc: not available
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20071213/e04f5f54/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: obj-uchar-dst.pgm
Type: application/octet-stream
Size: 262159 bytes
Desc: not available
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20071213/e04f5f54/attachment-0001.obj>