[vsipl++] [patch] Source configuration for package.py

[Stefan Seefeld]

Jules Bergmann wrote:
> This patch adds a source configuration input to the package.py script.
> It is intended for the 1.3 branch, but will also go into trunk.
> 
> The source configuration is a file that describes which SVN directories
> and revisions to check out to build a source package, as well as a list
> of patches to apply after checkout.
> 
> A source configuration to build the 1.3.1 release using the commercial
> FFTW will look something like:
> 
>     cfg.svpp_dir='csl/vpp/branches/1.3'
>     cfg.fftw_dir='csl/fftw-commercial/trunk'
>     cfg.patches=['docbook.diff']
> 
> The directories are SVN paths relative to /svk/Repository.  By default,
> the HEAD revision is checked out, but another revision could be
> specified by setting 'cfg.svpp_rev'.

Jules,

I have a couple of high-level questions:

1) Why do you keep the source configuration in a new file, instead of
   integrating it into the existing 'config' machinery ? (I'd really like
   to be able to integrate these changes into our buildbot setup at some
   point, so we can easily drive the whole release candidate testing by
   the same harness as everything else (as we used to, at least :-) ).

2) Why do we apply patches to a fftw working copy, as opposed to keeping
   them merged in the repository ? (why don't we use a branch for that ?)

3) How is the fftw working copy combined with the vpp working copy after
   the checkout ? (sorry if that is obvious from the code, I couldn't find
   the related code)

Thanks,
		Stefan

-- 
Stefan Seefeld
CodeSourcery
stefan at codesourcery.com
(650) 331-3385 x718