[vsipl++] [patch] Fast convolution enhancments

[Don McCoy]

Checked in with noted minor changes.

Don



Jules Bergmann wrote:
> > +    // Note: for a matrix of coefficients, unique rows are 
> transferred.
> > +    // For the normal case, the address is constant because the same
> > +    // vector is sent repeatedly.
>
> Is a single vector really sent repeatedly?  Shouldn't this be:
>
> "... the address is constant because a single vector is sent once and
> used repeatedly."
>
Er, yes.  Thanks for catching that!


> > -  Fastconv_base(Vector<T, Block> coeffs, length_type input_size,
> > +  Fastconv_base(Vector<T, Block> coeffs, Domain<dim> input_size,
>
> It should be more efficient to pass Domains as const references.  This
> avoids the need to call Domain's copy constructor.
>
Done.

>
> > +  // Member data.
> > +  Domain<dim> input_size_;
>
> Is input_size_ used?
>
No.  Removed.


-- 
Don McCoy
don (at) CodeSourcery
(888) 776-0262 / (650) 331-3385, x712