[vsipl++] [patch] Fixes for building benchmarks with IPP (and MPI)

[Jules Bergmann]

Don McCoy wrote:
> This patch does the following:
> 
>    * adds missing includes for several of the IPP benchmarks
>    * removes two dependencies on headers in tests/ for the benchmarks
>      (by moving them to vsip_csl/)
>    * changes the standalone benchmarks makefile to exclude MPI-specific
>      benchmarks by default
>    * corrects a missing definition needed in the benchmark's makefile
>      for detecting whether or not MPI is used

Don,

This looks good.  I have one comment below, please check it in once that 
is addressed.

				thanks,
				-- Jules

> Index: GNUmakefile.in
> ===================================================================
> --- GNUmakefile.in	(revision 148805)
> +++ GNUmakefile.in	(working copy)
> @@ -116,8 +116,8 @@
>  VSIP_IMPL_SAL_FFT := @VSIP_IMPL_SAL_FFT@
>  VSIP_IMPL_IPP_FFT := @VSIP_IMPL_IPP_FFT@
>  VSIP_IMPL_FFTW3 := @VSIP_IMPL_FFTW3@
> +VSIP_IMPL_MPI_H := @VSIP_IMPL_MPI_H@

Since VSIP_IMPL_MPI_H is used here as a boolean (1 if MPI is present), 
and is used elsewhere as the name of the MPI header file, can you call 
it something else to avoid confusion -- for example VSIP_IMPL_MPI or 
VSIP_IMPL_HAVE_MPI?


> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 148805)
> +++ configure.ac	(working copy)
> @@ -858,7 +858,8 @@
>        vsipl_par_service=0
>        CPPFLAGS="$save_CPPFLAGS"
>      fi
> -  else
> +  else 
> +    AC_SUBST(VSIP_IMPL_MPI_H, 1)
>      AC_DEFINE_UNQUOTED([VSIP_IMPL_MPI_H], $vsipl_mpi_h_name,
>      [The name of the header to include for the MPI interface, with <> quotes.])


-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705