[vsipl++] [patch] SSAR Make targets

[Don McCoy]

Stefan Seefeld wrote:
> What is the effect of "ssar_type = SSAR_BASE_TYPE=double" in a (GNU) makefile ?
> We usually use the ':=' assignment operator whenever possible. The only reason
> not to do that is if we have to evaluate the assinment lazily (i.e. because it
> refers to an expression of variables with yet unknown values).
>
>
>   

Corrected.


>   
>> Index: apps/ssar/load_save.hpp
>> ===================================================================
>>
>>     
> Please never, ever, use a 'using namespace' declaration in global scope in a header.
> I understand that here it isn't dangerous since this is not a library, but it is still
> confusing, and error-prone.
>
>   

This was done in a number of cases during development, but I've tried to 
weed them all out.  I hope this was one of the last... load_save.hpp is 
no longer used.


>> Index: apps/ssar/diffview.cpp
>>
>>     
> Why not
>
>
>      std::cerr << "Usage: " << arv[0] << "[-rn] <input> <reference> <rows> <cols>" << std::endl;
>
> ?
>
> Now we are using both, std::iostreams, as well as stdio. I think we should use one consistently.
>   

I agree and believe it's already been changed.  Do you have an old copy?

In any case, thanks for catching these things!  I found it was including 
"stdlib.h", so I removed that.



The attached patch fixes these two things.  Committed.

Regards,

-- 
Don McCoy
don (at) CodeSourcery
(888) 776-0262 / (650) 331-3385, x712

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ssarmake3.changes
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20061129/bc0bb3f4/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ssarmake3.diff
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20061129/bc0bb3f4/attachment-0001.ksh>