[vsipl++] [patch] Scalable SAR benchmark

[Don McCoy]

Jules Bergmann wrote:
> This looks good, I have three suggestions below, otherwise it looks
> good to check in.
>
> You could define these by-value versions in terms of the above
> by-reference versions:
>
>      Vector<T1> out(nx);
>      fftshift(in, out);
>      return out;
>    }
>
> Also, because you don't know what Block1 is, you should use
> 'Vector<T1>' (defaulting to a Dense block) instead of 'Vector<T1,
> Block1>'.  For example, Block1 could be a subblock type which can't be
> used in this context.  This affects both the defn of out, and the
> return type of the function.
>
I've addressed both of these.


>
> You could use a 'using vsip_csl::matlab::fftshift' in the function
> body.
>
>
That helps readability.  Thanks for the suggestions. 


Committed with the attached changes.

-- 
Don McCoy
don (at) CodeSourcery 
(888) 776-0262 / (650) 331-3385, x712

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fftshift2.diff
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20061102/a0d00d28/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fftshift2.changes
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20061102/a0d00d28/attachment-0001.ksh>