[vsipl++] Matalb IO patch

Stefan Seefeld stefan at codesourcery.com
Tue May 23 17:17:03 UTC 2006


Assem,

you are on the right way. However, the following issues aren't addressed yet:

* naming issues (redundant 'matlab_' prefixes, as well as some abbreviated
   names such as 'mtrx' and 'hdr', presumably for 'matrix' and 'header')

* dummy constructors with default values that don't appear to be useful

* operator<< not taking const reference for input argument type

* using string::c_str() instead of string::data() (and strcpy instead of strncpy)
   to access content

* using temporary buffer instead of writing directly to output

* Using a C-style cast to dump a compound type as a character buffer,
   which isn't portable (also see Mark's mail concerning float and double
   binary encoding).


Thanks,
		Stefan



More information about the vsipl++ mailing list