[vsipl++] Matlab IO

[Mark Mitchell]

Assem Salama wrote:
> Everyone,
>  This patch adds support for Matlab M file output. I only did diff in
> src/vsip_csl  because I'm chainging other stuff.

> +all:: lib/libvsip_csl.a

Is this a new library?  If so, why?  We can put this in the ordinary
VISPL++ library.

> Index: matlabformatter.hpp
> ===================================================================
> RCS file: matlabformatter.hpp
> diff -N matlabformatter.hpp
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ matlabformatter.hpp	19 May 2006 15:59:06 -0000
> @@ -0,0 +1,103 @@

You're missing the usual header-file comments, copyright notice, etc.

> +  //template <template <typename,typename> class ViewT>

Do not check in commented-out code.  Be disciplined; review your
changes, and remove any #if 0'd or commented-out code.

> +      MatlabFormatter(ViewT v) : v_(v), view_name_("a")  {}

I don't think it makes sense to write out an imaginary view name.

Matlab m-files are code; there is a Matlab programming language.
Something like:

  a = [ ... ]

is a statement.  But, a view is just an expression, not a whole
statement.  Just write out the part inside the square brackets.

-- 
Mark Mitchell
CodeSourcery
mark at codesourcery.com
(650) 331-3385 x713