[vsipl++] [patch] double support for SAL LU solver

[Don McCoy]

Jules Bergmann wrote:
> 
> This looks good.  Can you:
> 
>  - Move the reciprocal call from sal_matfbs to sal_matlud.  That way
>    if multiple sal_matfbs calls are made (either because B/X have
>    multiple columns, or because the LU object is used multiple times),
>    vrecip will only get called once.
> 
>  - Create a typedef for the block_type of recip_.  That way the Ext_data
>    for recip_ is guaranteed to have the correct block type if recip_
>    ever changes.
> 
>  - a few more comments sprinkled below.
> 
> If these comments make sense, once you address them this looks good to 
> check in.

Committed with suggested changes.  Thanks for catching those things.

> 
> How do we test this?  By manually disabling the the mat_trans and 
> mat_herm cases?
> 

Exactly.


-- 
Don McCoy
don (at) CodeSourcery
(888) 776-0262 / (650) 331-3385, x712
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: lu2.diff
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20060507/fc2f1032/attachment.ksh>