[vsipl++] CLAPACK

[Jules Bergmann]

Assem,

Looks good.  Comments below.  -- Jules

> 
> ------------------------------------------------------------------------
> 
> Index: make.inc.in
> ===================================================================
> RCS file: /home/cvs/Repository/clapack/make.inc.in,v
> retrieving revision 1.1
> diff -u -r1.1 make.inc.in
> --- make.inc.in	21 Mar 2006 13:38:28 -0000	1.1
> +++ make.inc.in	21 Mar 2006 17:31:33 -0000
> @@ -8,9 +8,10 @@
>  #
>  #  The machine (platform) identifier to append to the library names
>  #
> -# leave PLAT empty for now
> +# Assem: we are now using configure to make this makefile. PLAT is used
> +# as a postfix for the library names. We want the library names to be the same
> +# regardless of platform, so, we will leave it empty.

Putting your name by the comment is OK, but not everyone might be able 
to figure out what "Assem:" means (or who to blame :) if they have a 
problem).

Instead of just "Assem:", could you end the comment with "(Assem Salama, 
CSI)" or "(Assem Salama, CodeSourcery)"?


> Index: ChangeLog
> ===================================================================
> RCS file: /home/cvs/Repository/vpp/ChangeLog,v
> retrieving revision 1.411
> diff -u -r1.411 ChangeLog
> --- ChangeLog	16 Mar 2006 03:27:10 -0000	1.411
> +++ ChangeLog	21 Mar 2006 18:15:15 -0000
> @@ -1,3 +1,18 @@
> +2006-03-21  Assem Salama <assem at codesourcery.com>
> +	* vendor: added CLAPACK library. CLAPACK now sits in clapack
> +	* CVSROOT/modules: added a line to automatically checkout CLAPACK when
> +		vpp is checked out

Technically, CVSROOT/modules isn't part of the VSIPL++ repository. 
Instead, could you say:

	* vendor/clapack: New directory, contains 'clapack' module,
           incorporated using CVSROOT/modules.

> +	* vendor/GNUmakefile.inc: to make CLAPACK instead of LAPACK. Also added
> +		a command for clean to also clean out CLAPACK when make clean
> +		is invoked
> +	* vendor/clapack/SRC/GNUmakefile.in: added this file to allow configure
> +		to make this directory. This file orginally was Makefile.

This is OK, but for new files it is nice if the phrase "new file" starts 
the comment.  Also, it is not clear which 'Makefile' the comment refers 
to.  How about:

	* vendor/clapack/SRC/GNUmakefile.in: New file, allow configure
	  to make this directory.  This file is derived from the clapack
	  Makefile in the same directory.

> +	* vendor/clapack/make.inc.in: added this file to have configure
> +		atuomatically fill compile variables
> +	* vendor/clapack/SRC/f2c.h: modified typedef of integer. integer used to
> +		be defined as 64 bits. Original FORTRAN code had integer defined
> +		for 32 bits.
> +
>  2006-03-15  Stefan Seefeld  <stefan at codesourcery.com>
>  
>  	* tests/*: Move various tests into subdirectories.


-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705