[vsipl++] Atlas patch

[Stefan Seefeld]

Assem,


Assem Salama wrote:

>  $(vendor_LIBF77):
>  	@echo "Building libF77 (see libF77.build.log)"
>  	@$(MAKE) -C vendor/clapack/F2CLIBS/libF77 all > libF77.build.log 2>&1
> -	@ln -s `pwd`/vendor/clapack/F2CLIBS/libF77/libF77.a vendor/atlas/lib/libF77.a

I notice you have taken out this and a couple of other link generations. What's the rationale
for that ?


>  
>  
>  install:: $(vendor_LIBF77)
> @@ -106,7 +107,6 @@
>  	@$(MAKE) -C vendor/clapack/F2CLIBS/libF77 clean > libF77.clean.log 2>&1
>  endif
>  
> -
>  clean::
>  	@echo "Cleaning ATLAS (see atlas.clean.log)"
>  	@$(MAKE) -C vendor/atlas clean > atlas.clean.log 2>&1
> @@ -125,6 +125,58 @@
>  endif # USE_FORTRAN_LAPACK
>  
>  endif # USE_BUILTIN_ATLAS
> +################################################################################
> +
> +ifdef USE_SIMPLE_LAPACK
> +all:: $(vendor_SIMPLE_BLAS) $(vendor_REF_LAPACK)
> +
> +libs += $(vendor_F77BLAS) $(vendor_REF_LAPACK)
> +
> +$(vendor_SIMPLE_BLAS):
> +	@echo "Building simple BLAS (see simpleBLAS.build.log)"
> +	@$(MAKE) -C vendor/clapack/blas/SRC all > simpleBLAS.build.log 2>&1
> +
> +ifdef USE_FORTRAN_LAPACK

Could you summarize / document the build logic a bit ? This last line
actually happens inside the 'ifdef USE_SIMPLE_LAPACK' conditional, so
the following targets are only defined if both variables (USE_SIMPLE_LAPACK as well
as USE_FORTRAN_LAPACK) are defined. Is that intended ?

> @@ -166,7 +218,7 @@
>  all:: $(vendor_FFTW_LIBS)
>  	@rm -rf vendor/fftw/include
>  	@mkdir -p vendor/fftw/include
> -	@ln -s $(abs_srcdir)/vendor/fftw/api/fftw3.h vendor/fftw/include/fftw3.h
> +	@ln -s $(srcdir)/vendor/fftw/api/fftw3.h vendor/fftw/include/fftw3.h

What's the rationale for this change ? I remember first using $(srcdir) which resulted in
incorrect links, as the target becomes a relative path, so the validity depends on the cwd when
dereferencing the link. Thus I replaced $(srcdir) by $(abs_srcdir) to make it work.

Thanks,
		Stefan


-- 
Stefan Seefeld
CodeSourcery
stefan at codesourcery.com
(650) 331-3385 x718