[vsipl++] SIMD

Jules Bergmann jules at codesourcery.com
Fri Jul 21 14:22:36 UTC 2006


Assem Salama wrote:
 > Everyone,
 >  This patch is for a CFAR update running sum SIMD instruction. I just
 > realized date in previous ChangeLog file is not correct, sorry about 
that.

Assem,

This looks good.  One minor comment, but otherwise it is ready to
check in.

Do you have a test for this?

				thanks,
				-- Jules

 > +#if 0
 > +// this order doesn't work correctly

Can you change this comment to indicate which compiler(s) you've
tried this with:

// This order of operations does not work correctly with
// GCC 3.4.  It is functionally equivalent to the order
// below, that does work.

 > +      reg4 = simd::add(reg4,reg0);
 > +      reg4 = simd::sub(reg4,reg2);
 > +      reg5 = simd::add(reg5,reg1);
 > +      reg5 = simd::sub(reg5,reg3);
 > +#else
 > +      reg0 = simd::sub(reg0,reg2);
 > +      reg4 = simd::add(reg4,reg0);
 > +      reg1 = simd::sub(reg1,reg3);
 > +      reg5 = simd::add(reg5,reg1);
 > +#endif

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705



More information about the vsipl++ mailing list