[patch] Fix png example failure, ICC fix

Jules Bergmann jules at codesourcery.com
Thu Jul 20 16:32:21 UTC 2006


This patch should fix the build failure with the png example program.

The problem was in the dispatch layer that re-evaluates a dense 
multi-dim expression as a 1-dim expression.  It has to "re-dimension" 
the expression template tree.  For Unary_expr_blocks, it was copying the 
operand block, but not the unary functor.  For most unary_expr_blocks 
this is OK, the unary functor's default constructor is fine.  However 
for unary_expr_blocks associated with user-defined elementwise functions 
(such as PNG's swap_read_green), this is not OK.  The functor needs to 
be copied.

This patch also fixes a compilation problem with ICC 9.1.  It was 
confused by impl in "impl::Scalar_of".  Instead of thinking it was a 
namespace, it thought it was a class.  Maying the namespace more 
explicit fixes it.  Fortunately, our coding standards (lower-case 
namespace names, upper-case Class names) make this an infrequent problem.

Patch applied.

				-- Jules

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ede.diff
URL: <http://sourcerytools.com/pipermail/vsipl++/attachments/20060720/764f5cdf/attachment.ksh>


More information about the vsipl++ mailing list