[vsipl++] [patch] Profiler Command Line Options

[Jules Bergmann]

Don McCoy wrote:
> This patch adds two new command line options related to profiling:
> 
>   --vsipl++-profile-mode={accum,trace}
>   --vsipl++-profile-output=/filename/
> 
> Both should normally be used together to enable the profiler, but if the 
> filename is omitted, the output will go to stdout.

Don,

This looks good!  Please check it in.

Oops, this patch made me think of another comment for the previous patch.

				thanks,
				-- Jules





> +#define MODE_OPTION    "--vsipl++-profile-mode"
> +#define MODE_LENGTH    (strlen(MODE_OPTION))
> +
> +#define OUTPUT_OPTION  "--vsipl++-profile-output"
> +#define OUTPUT_LENGTH  (strlen(OUTPUT_OPTION))

I was going to make the following comment:

Any macros that we define in the library should be prefixed by 
"VSIP_IMPL_", even those that we later undefine.  The reason for this is 
that a user program may define those macros before including the library 
file.

However, this does not apply to macros in .cpp files, so no problemo.

It does apply to the PROFILING_ENABLED macro in the previous patch.

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705