[vsipl++] [patch] HPEC benchmark makefiles

[Jules Bergmann]

Don McCoy wrote:
> The attached patch moves the HPEC Kernel benchmarks to their own 
> directory in benchmarks/hpec-kernel/ and includes new makefiles for both 
> developers and users.
> 
> It also fixes an oversight from when the vsip_csl directory was added - 
> i.e. the installation of this directory when 'make install' is invoked. 
>  For this, a new makefile was created.  It also contains some of the 
> directives needed for when we add .cpp files to the extensions library, 
> although they are not being used at this time.
> 

Don,

This looks good.  Please check it in.  thanks, -- Jules



> Index: benchmarks/hpec-kernel/GNUmakefile.inc.in
> ===================================================================
> RCS file: benchmarks/hpec-kernel/GNUmakefile.inc.in
> diff -N benchmarks/hpec-kernel/GNUmakefile.inc.in
> *** /dev/null	1 Jan 1970 00:00:00 -0000
> --- benchmarks/hpec-kernel/GNUmakefile.inc.in	12 Apr 2006 07:22:58 -0000
> ***************
> *** 0 ****
> --- 1,43 ----
> + ######################################################### -*-Makefile-*-
> + #
> + # File:   GNUmakefile.inc.in
> + # Author: Don McCoy
> + # Date:   2006-04-11
> + #
> + # Contents: Makefile fragment for HPEC benchmarks.
> + #
> + ########################################################################
> + 
> + ########################################################################
> + # Variables
> + ########################################################################
> + 
> + benchmarks_hpec-kernel_CXXINCLUDES := -I$(srcdir)/benchmarks
> + benchmarks_hpec-kernel_CXXFLAGS := $(benchmarks_hpec-kernel_CXXINCLUDES)

Does gnumake allow variable names with "-" in them?  If so, this is OK.

If not, let's replace the "-" with a "_" (and update the GNUmakefile.in 
'norm_dir' function accordingly).


> Index: src/vsip_csl/GNUmakefile.inc.in
> ===================================================================
> RCS file: src/vsip_csl/GNUmakefile.inc.in
> diff -N src/vsip_csl/GNUmakefile.inc.in
> *** /dev/null	1 Jan 1970 00:00:00 -0000
> --- src/vsip_csl/GNUmakefile.inc.in	12 Apr 2006 07:22:58 -0000
> ***************
> *** 0 ****
> --- 1,43 ----
> + ######################################################### -*-Makefile-*-
> + #
> + # File:   GNUmakefile.inc
> + # Author: Don McCoy
> + # Date:   2006-04-11
> + #
> + # Contents: Makefile fragment for src/vsip_csl.
> + #
> + ########################################################################
> + 
> + ########################################################################
> + # Variables
> + ########################################################################
> + 
> + src_vsip_csl_CXXINCLUDES := -I$(srcdir)/src
> + src_vsip_csl_CXXFLAGS := $(src_vsip_csl_CXXINCLUDES)
> + 
> + src_vsip_csl_cxx_sources := $(wildcard $(srcdir)/src/vsip/*.cpp)
> + 
> + src_vsip_csl_cxx_objects := $(patsubst $(srcdir)/%.cpp, %.$(OBJEXT), \
> + 	                               $(src_vsip_csl_cxx_sources))
> + cxx_sources += $(src_vsip_csl_cxx_sources)
> + 
> + #libs += src/vsip/libvsip.a
> + ########################################################################
> + # Rules
> + ########################################################################
> + 
> + all:: src/vsip/libvsip.a
> + 
> + #clean::
> + #	rm -f src/vsip/libvsip_csl.a
> + 
> + #src/vsip/libvsip.a: $(src_vsip_csl_cxx_objects)
> + #	$(AR) rc $@ $^ || rm -f $@

Are these commented out because vsip_csl does not have any object files yet?

Would they cause an error if "commented in"?  If possible, let's do that.

-- 
Jules Bergmann
CodeSourcery
jules at codesourcery.com
(650) 331-3385 x705