[vsipl++] [patch] load_view and save_view for tests

Stefan Seefeld stefan at codesourcery.com
Fri Sep 30 22:01:26 UTC 2005


Jules,

shouldn't we try to consistently use <iostream> instead of <stdio.h> ?

Jules Bergmann wrote:

> +   Load_view(char*                    filename,
> + 	    vsip::Domain<Dim> const& dom)
> +     : data_  (new base_t[factor*dom.size()]),
> +       block_ (dom, data_),
> +       view_  (block_)
> +   {
> +     FILE*  fd;
> +     size_t size = dom.size();
> +     
> +     if (!(fd = fopen(filename,"r")))

It might be better to use "rb" as the mode, just to avoid headaches if
we try to port the code to non-POSIX systems one day.

Regards,
		Stefan



More information about the vsipl++ mailing list