[PATCH] ipp.cpp, sal.cpp, FIR cleanup

[Nathan (Jasper) Myers]

I have checked in the following patch.

It does minor cleanup in ipp.cpp, sal.cpp (sorry Don), documents
some members and removes a FIXME in signal-fir.hpp.

Nathan Myers
ncm

Index: ChangeLog
===================================================================
RCS file: /home/cvs/Repository/vpp/ChangeLog,v
retrieving revision 1.297
diff -u -p -r1.297 ChangeLog
--- ChangeLog	25 Oct 2005 23:53:26 -0000	1.297
+++ ChangeLog	27 Oct 2005 17:49:12 -0000
@@ -1,3 +1,9 @@
+2005-10-27  Nathan Myers  <ncm at codesourcery.com>
+
+	* src/vsip/impl/ipp.cpp, sal.cpp: remove inglorious #ifdefs.
+	* src/vsip/impl/signal-fir.hpp: document FIR driver control flags,
+	  remove FIXME for logged spec bug.
+
 2005-10-25  Nathan Myers  <ncm at codesourcery.com>
 
 	* src/vsip/impl/ipp.cpp, src/vsip/impl/signal-fir.hpp:
Index: src/vsip/impl/ipp.cpp
===================================================================
RCS file: /home/cvs/Repository/vpp/src/vsip/impl/ipp.cpp,v
retrieving revision 1.6
diff -u -p -r1.6 ipp.cpp
--- src/vsip/impl/ipp.cpp	25 Oct 2005 23:53:26 -0000	1.6
+++ src/vsip/impl/ipp.cpp	27 Oct 2005 17:49:12 -0000
@@ -10,10 +10,6 @@
   Included Files
 ***********************************************************************/
 
-#include <vsip/impl/acconfig.hpp>
-
-#if defined(VSIP_IMPL_HAVE_IPP)
-
 #include <vsip/math.hpp>
 #include <vsip/signal.hpp>
 #include <vsip/impl/ipp.hpp>
@@ -267,5 +263,3 @@ template struct Ipp_fir_driver<std::comp
 } // namespace vsip::impl::ipp
 } // namespace vsip::impl
 } // namespace vsip
-
-#endif /* VSIP_IMPL_HAVE_IPP */
Index: src/vsip/impl/sal.cpp
===================================================================
RCS file: /home/cvs/Repository/vpp/src/vsip/impl/sal.cpp,v
retrieving revision 1.2
diff -u -p -r1.2 sal.cpp
--- src/vsip/impl/sal.cpp	24 Oct 2005 13:25:30 -0000	1.2
+++ src/vsip/impl/sal.cpp	27 Oct 2005 17:49:12 -0000
@@ -7,8 +7,6 @@
                Mercury SAL.
 */
 
-#if defined(VSIP_IMPL_HAVE_SAL)
-
 /***********************************************************************
   Included Files
 ***********************************************************************/
@@ -314,5 +312,3 @@ void vdiv(std::pair<double*, double*> co
 } // namespace vsip::impl::sal
 } // namespace vsip::impl
 } // namespace vsip
-
-#endif
Index: src/vsip/impl/signal-fir.hpp
===================================================================
RCS file: /home/cvs/Repository/vpp/src/vsip/impl/signal-fir.hpp,v
retrieving revision 1.5
diff -u -p -r1.5 signal-fir.hpp
--- src/vsip/impl/signal-fir.hpp	25 Oct 2005 23:53:26 -0000	1.5
+++ src/vsip/impl/signal-fir.hpp	27 Oct 2005 17:49:12 -0000
@@ -44,8 +44,13 @@ struct Fir_aligned
 template <typename T>
 struct Fir_driver
 {
+  // Does this driver expect the kernel to be stored in reverse order?
   static const bool  reverse_kernel = true;
+
+  // Should the native C++ implementation always be used for T?
   static const bool  use_native = true;
+
+  // Does this driver tolerate decimation and block size relatively prime?
   static const bool  mismatch_ok = true;
 
   // code that calls this should be elided by the optimizer.
@@ -65,6 +70,7 @@ namespace ipp
 template <typename T>
 struct Ipp_fir_driver
 {
+  // See Fir_driver above for documentation of the following.
   static const bool  reverse_kernel = false;
   static const bool  use_native = false;
   static const bool  mismatch_ok = false;
@@ -167,7 +173,6 @@ public:
     }
   }
 
-  // FIXME: spec says this should be nothrow, but it has to allocate
   Fir(Fir const& fir)  VSIP_THROW((std::bad_alloc))
   : input_size_(fir.input_size_)
   , output_size_(fir.output_size_)