[qmtest] patch: Various enhancements and fixes

Mark Mitchell mark at codesourcery.com
Fri Jun 2 22:25:26 UTC 2006


Stefan Seefeld wrote:

>> What is the logic for this change?  We're in __debug__ so we know assert
>> will work.  I'm fine with the change; I'm just curious as to the reason.
> 
> I was running some extension class that I passed a wrong attribute in its
> constructor, and all I got was an assertion error, i.e. no information
> about what the wrong attribute was. The above change was the only way
> for me to see what I did wrong.

OK, that makes sense.

>> What do you mean "boolean value"?  It looks like you just return
>> default.  It also seems like "[]" would be a better default.
> 
> Sorry, I was mindlessly c&p'ing (from 'GetBoolean()').

OK.

> In fact, whenever 'default' is not None, it is returned if there
> is no variable associated with 'key'. Thus, users who want to
> provide an empty list as default value should call the function
> as 'GetStringList(key, [])'.

OK.  Please check in the patch.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark at codesourcery.com
(650) 331-3385 x713



More information about the qmtest mailing list