[qmtest] work around bug in distutils version <= 1.0.3

Mark Mitchell mark at codesourcery.com
Wed Jan 5 23:59:45 UTC 2005


Stefan Seefeld wrote:
> Hi there,
> 
> the attached patches provide a custom 'build_scripts' command
> that makes scripts executable. It is required on posix systems
> when the python version is < 2.3.
> 
> A much simpler fix was already part of the GNUMakefile, but as
> I would like to complete the transition from configure/make
> to distutils, this step is required in order to make the old
> build system fully obsolete.

Yay!

This patch looks fine to me.  We normally capitalize sentences in 
comments, though so for:

    # the original command is good enough.

and:

             # work around distutils bug (for python > 2.3)
             # change permissions to executable.

using complete sentences with a capital letter and a period would be nice.

-- 
Mark Mitchell
CodeSourcery, LLC
mark at codesourcery.com
(916) 791-8304



More information about the qmtest mailing list