[qmtest] Bug with editing attachments

[Vladimir Prus]

Hi Mark,

> > Hello,
> > using CVS HEAD of QMTest, I have problems with attachments.
>
> Volodya --
>
> I've (finally!) gotten around to fixing this problem, I think.
>
> Here's a patch which cleans up the Attachment abstractions
> substantially.  I've checked in the patch, but I'd appreciate it if you
> would try it out and let me know if it works for you.

Oh... looks like a big patch! But as I see, the essense is that now attachment 
rendered in HTML knows which store it comes from. That's great -- I myself 
did not know how to implement this in right way.

The problems with editing test that has an attachment are now gone. 

However, the other problem is still there. If I create a new test with 
attachment, the location is like this:

   <location>/home/ghost/Work/Module/nm_model/tdb/history.qms/nightly.sh</location>

Which would make test break if I ever decide to move my working copy -- of if 
tests are run on a different machine. I'd still say that the 
__MakeDataFilePath in xml_database is not right. It would be better to use 
methods of AttachmentStore, rather than checking for file existance via 
"os.path.exists" -- as it stands, it depends on the exact way 
FileAttachmentStore works.

I would have tried to write a patch for this, but alas, I still can't quite 
finish my patch for using separate color for failed and unexpected results,
so prefer not to promise anything until I'm done ;-)


- Volodya