[qmtest] TET result stream

Mark Mitchell mark at codesourcery.com
Thu Feb 19 20:01:44 UTC 2004


Nathaniel Smith wrote:

> Wow, this was more annoying than I expected, but, here's what I think
> is a working TET-emulating result stream[1].  The code feels a bit
> grungy, but it's not obvious to me how to fix it up; it may be that
> the TET journal format is just that grungy.  Anyway, comments and
> review requested.

Nice work.

>     def _WriteInitialStuff(self):

Since this function is not an override (or, at least I don't *think* it 
is), it should have a doc string.  That goes for the other non-override 
functions as well.

>                         "%i %s 00:00:00"

As I mentioned on IRC, I'd like to see us use a valid time here.  I 
suggest extending QMTest to collect start/stop time for tests; I can see 
that being useful to other people as well.

>         # I don't know what completion status means; it is zero in all of the
>         # documented examples.

Let's not have the first person singular appear in comments.  One always 
wonders "who was I?" later.

You could just say "the completion status is zero in all of the 
documented examples".  But, we can also see if we can figure out how 
that is supposed to work.  I've updated our internal Wiki with the email 
address of the people to ask.

You can check it in without resolving that, though -- just fix up the 
other minor issues above.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark at codesourcery.com



More information about the qmtest mailing list