[qmtest] [PATCH] Fix open_temporary_file_fd

[Nathaniel Smith]

On Sun, Feb 15, 2004 at 12:38:38PM -0800, Mark Mitchell wrote:
> Nathaniel Smith wrote:
> 
> >Attached patch fixes regressions caused by changes to
> >open_temporary_file_fd.
> 
> Oh, bummer.  I only tested on Windows, as is clear.
> 
> >Okay to apply?  Feels ugly, using the if there, but I guess the
> >function'll get ripped out entirely when we start assuming Python
> >2.3...
> 
> I'm disappointed that "mktemp" doesn't do the right thing with a "None"
> argument.  Maybe using the empty string ("") as the default (instead of 
> None) would be the right choice and avoid the conditional?

Hmm, for some reason I was thinking that mktemp was documented to add
a "default suffix" rather than "no suffix", so I didn't do that.  But
I was wrong.  Applied with that change to both HEAD and
release-2-1-branch.

-- Nathaniel

-- 
When the flush of a new-born sun fell first on Eden's green and gold,
Our father Adam sat under the Tree and scratched with a stick in the mould;
And the first rude sketch that the world had seen was joy to his mighty heart,
Till the Devil whispered behind the leaves, "It's pretty, but is it Art?"
  -- The Conundrum of the Workshops, Rudyard Kipling