[qmtest] [PATCH] Make dotted context keys available in the environment.
Nathaniel Smith
njs at pobox.com
Mon Aug 11 19:37:38 UTC 2003
On Mon, Aug 11, 2003 at 12:13:12PM -0700, Mark Mitchell wrote:
> Cool.
>
> + For example, a context variable
> + "CompilerTable.c_path" would correspond to an
> + environment variable
> + "<envar>QMV_CompilerTable__c_path</envar>".</para>
>
> I suggest you reword this as:
>
> For example, the value of the context property "CompilerTable.c_path" is
> available as the
> value of the environment variable "QMV_CompilerTable__c_path".
Yeah, that is better.
> + # And if there is a context file, use it.
> + if os.path.exists(context_file):
> + argv += ("-C", context_file)
>
> I believe that (from looking at cmdline.py) that a file named "context" will
> be used implicitly if no other context file is provided. So, this code is
> probably redundant and can be omitted.
It's not, actually; cmdline.py checks for a file "context" in the
current directory only, and we don't chdir to the test directories
while running the regression suite. I suppose I could add logic for
that instead, but this way seems cleaner.
-- Nathaniel
--
Sentience can be such a burden.
More information about the qmtest
mailing list