qmtest-1.1.5 patch to handle tests with no matching target

Sven Lundblad svlu at enea.se
Wed Sep 25 15:18:29 UTC 2002


Hi all,

We use qmtest 1.1.5 with different target specification files to control
on which targets tests run. However qmtest 1.1.5 hangs and never exists
if there are tests that do not match any target so we made a patch in
the execution engine to remove tests that can never be run (due to lack
of a target).

We more or less consider this to be a bug in qmtest, do you guys agree?

Regards,
Sven Lundblad

Patch produced with: diff -ru qm-1.1.5 qm-1.1.5-ose
--- qm-1.1.5/qm/test/execution_engine.py        Wed May 15 03:50:19 2002
+++ qm-1.1.5-ose/qm/test/execution_engine.py    Wed Sep 25 16:53:34 2002
@@ -220,6 +220,16 @@
                         # iteration.
                         wait = 0
                         break
+                else:
+                    # If all targets are idle and no match found then
+                    # remove the test from the ready queue and mark it
+                    # as untested.
+                    if(len(self.__idle_targets) ==
len(self.__targets)):
+                        self.__ready.remove(descriptor)
+                        self.__pending.remove(descriptor)
+                        self._AddUntestedResult(descriptor.GetId(),
+                            qm.message("no target for group"))
+                        wait = 0

                 if not wait:
                     break
-- 
---
Sven Lundblad, OSE Systems



More information about the qmtest mailing list