[qmtest] [PATCH] Add 'run this test' menu item to results page

Vladimir Prus ghost at cs.msu.su
Thu Nov 28 07:02:18 UTC 2002


Mark Mitchell wrote:
> 
> 
> --On Wednesday, November 13, 2002 03:47:11 PM +0300 Vladimir Prus 
> <ghost at cs.msu.su> wrote:
> 
>>
>> Hello,
>> I constantly encounter this situation: a test fails,
>> I click on "details" to find out what happened, fix
>> something and want to rerun the test. Now, I have to
>> click on test name and then select "Run -> This test".
> 
> 
> Volodya --
> 
> I checked in this patch.

Great!

> Two notes for the future:
> 
> (1) We put two lines betwen functions, so:
> 
>    +        self.run_menu_items.append(("This Test", "run_test();"))
>    +
>    +    def MakeRunUrl(self):
> 
>    needed another blank line.

OK, noted.

> 
> (2) Please submit a ChangeLog entry with your patch so that we can see
>    what you're changing at a glance.

OK. I kinda dislike GNU ChangeLog style, because it omits the
purpose of the changes and describes only individual file tweaks, but
I guess I can just sumbit "full" changelog and let you pick the
parts that's needed.

- Volodya




More information about the qmtest mailing list