[pooma-dev] [PATCH] Add missing #includes

[James Crotinger]

Hi Richard,

If you add <iostream> you should remove <iosfwd>, though it is generally
better to use the latter in a header if it only needs references (on some
platforms, unnecessary includes of iostream have made significant
differences in compile speed, and at one point, including <iostream> was
verboten in public header files, though I think this decision was ultimately
abandoned).

	Jim

------------------------------------------------------------------------
James A. Crotinger                           email:     jimc at numerix.com
NumeriX, LLC                                 phone:  (505) 424-4477 x104
2960 Rodeo Park Dr. W.
Santa Fe, NM 87505
 

> -----Original Message-----
> From: Richard Guenther [mailto:rguenth at tat.physik.uni-tuebingen.de]
> Sent: Monday, March 15, 2004 3:28 AM
> To: pooma-dev at pooma.codesourcery.com
> Cc: Jeffrey D. Oldham
> Subject: [pooma-dev] [PATCH] Add missing #includes
> 
> Hi!
> 
> A first step cleaning up #includes.  Makes more headers pass generation of
> a precompiled header.  Next step is to remove unnecessary #includes.
> 
> Ok?
> 
> Richard.
> 
> 
> 2004Mar15  Richard Guenther <richard.guenther at uni-tuebingen.de>
> 
> 	* src/Domain/DomainMap.h: add missing #include.
> 	src/Domain/NewDomain.h: likewise.
> 	src/Evaluator/MultiArgEvaluator.h: likewise.
> 	src/Evaluator/MultiArgKernel.h: likewise.
> 	src/Evaluator/SimpleIntersector.h: likewise.
> 	src/Functions/MultiArg.h: likewise.
> 
> Index: Domain/DomainMap.h
> ===================================================================
> RCS file: /home/pooma/Repository/r2/src/Domain/DomainMap.h,v
> retrieving revision 1.20
> diff -u -u -r1.20 DomainMap.h
> --- Domain/DomainMap.h	10 Oct 2003 19:26:43 -0000	1.20
> +++ Domain/DomainMap.h	15 Mar 2004 10:24:10 -0000
> @@ -58,6 +58,7 @@
>  #include <utility>
>  #include <list>
>  #include <iosfwd>
> +#include <iostream>
> 
> 
> 
> //////////////////////////////////////////////////////////////////////////
> /////
> Index: Domain/NewDomain.h
> ===================================================================
> RCS file: /home/pooma/Repository/r2/src/Domain/NewDomain.h,v
> retrieving revision 1.34
> diff -u -u -r1.34 NewDomain.h
> --- Domain/NewDomain.h	12 Oct 2003 11:14:38 -0000	1.34
> +++ Domain/NewDomain.h	15 Mar 2004 10:24:12 -0000
> @@ -65,6 +65,7 @@
> 
>  #include "Domain/DomainTraits.h"
>  #include "Utilities/PAssert.h"
> +#include "Utilities/NoInit.h"
> 
>  //-----------------------------------------------------------------------
> ------
>  // Forward Declarations:
> Index: Evaluator/MultiArgEvaluator.h
> ===================================================================
> RCS file: /home/pooma/Repository/r2/src/Evaluator/MultiArgEvaluator.h,v
> retrieving revision 1.14
> diff -u -u -r1.14 MultiArgEvaluator.h
> --- Evaluator/MultiArgEvaluator.h	21 Nov 2003 17:36:10 -0000	1.14
> +++ Evaluator/MultiArgEvaluator.h	15 Mar 2004 10:24:14 -0000
> @@ -64,6 +64,8 @@
>  //-----------------------------------------------------------------------
> ------
> 
>  #include "Engine/Intersector.h"
> +#include "Evaluator/EvaluatorTags.h"
> +#include "Evaluator/RequestLocks.h"
>  #include "Evaluator/MultiArgKernel.h"
>  #include "Evaluator/SimpleIntersector.h"
>  #include "Evaluator/ScalarCodeInfo.h"
> Index: Evaluator/MultiArgKernel.h
> ===================================================================
> RCS file: /home/pooma/Repository/r2/src/Evaluator/MultiArgKernel.h,v
> retrieving revision 1.3
> diff -u -u -r1.3 MultiArgKernel.h
> --- Evaluator/MultiArgKernel.h	22 Oct 2003 20:43:26 -0000	1.3
> +++ Evaluator/MultiArgKernel.h	15 Mar 2004 10:24:14 -0000
> @@ -61,8 +61,10 @@
>  //-----------------------------------------------------------------------
> ------
> 
>  #include "Engine/EngineFunctor.h"
> +#include "Evaluator/RequestLocks.h"
>  #include "Evaluator/LoopApply.h"
>  #include "Functions/MultiArg.h"
> +#include <vector>
> 
>  //-----------------------------------------------------------------------
> ------
>  // Forward Declarations:
> Index: Evaluator/SimpleIntersector.h
> ===================================================================
> RCS file: /home/pooma/Repository/r2/src/Evaluator/SimpleIntersector.h,v
> retrieving revision 1.6
> diff -u -u -r1.6 SimpleIntersector.h
> --- Evaluator/SimpleIntersector.h	22 Oct 2003 20:43:26 -0000	1.6
> +++ Evaluator/SimpleIntersector.h	15 Mar 2004 10:24:15 -0000
> @@ -55,10 +55,16 @@
>  //-----------------------------------------------------------------------
> ------
> 
>  #include "Engine/EngineFunctor.h"
> +#include "Layout/INode.h"
> +#include "Utilities/RefCounted.h"
> +#include "Utilities/RefCountedPtr.h"
> 
>  //-----------------------------------------------------------------------
> ------
>  // Forward Declarations:
>  //-----------------------------------------------------------------------
> ------
> +
> +template <class LayoutTag, class PatchTag, int Dim2>
> +class MultiPatchView;
> 
>  //-----------------------------------------------------------------------
> ------
>  //
> Index: Functions/MultiArg.h
> ===================================================================
> RCS file: /home/pooma/Repository/r2/src/Functions/MultiArg.h,v
> retrieving revision 1.9
> diff -u -u -r1.9 MultiArg.h
> --- Functions/MultiArg.h	25 Oct 2003 12:06:55 -0000	1.9
> +++ Functions/MultiArg.h	15 Mar 2004 10:24:16 -0000
> @@ -70,6 +70,7 @@
>  //-----------------------------------------------------------------------
> ------
> 
>  #include "Pooma/View.h"
> +#include <vector>
> 
>  //-----------------------------------------------------------------------
> ------
>  // Forward Declarations:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://sourcerytools.com/pipermail/pooma-dev/attachments/20040315/337c26d1/attachment.html>