[pooma-dev] Re: [PATCH] Kill Unwrap<>

[Jeffrey D. Oldham]

Richard Guenther wrote:
> On Mon, 19 Jan 2004, Jeffrey D. Oldham wrote:
> 
> 
>>Richard Guenther wrote:
>>
>>>Hi!
>>>
>>>This patch kills previously introduced Unwrap<> and instead provides a
>>>fallback in OpMask<>.  This way we don't forget places to update (as I did
>>>with PartialReduction in case of OpenMP).
>>>
>>>Tested on serial ia64 linux with no regressions.
>>>
>>>Ok?
>>
>>Thanks for fixing this.  I agree it's a good idea to have the default
>>values do the right thing.  Are there any other operators that need
>>modification as well?  Is it OK to have an additional if in the Where
>>operator?  Will this impact performance?
> 
> 
> It's really only the WhereProxy and its OpMask wrapping operator that is
> this special. Performance should be unaffected.

Good.  Thanks.  Please commit the patch.

-- 
Jeffrey D. Oldham
oldham at codesourcery.com